Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception thrown when expression is too short #335

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix exception thrown when expression is too short #335

merged 2 commits into from
Aug 21, 2020

Conversation

alonsodomin
Copy link
Owner

Fixes #327

@codecov
Copy link

codecov bot commented Aug 21, 2020 •
edited
Loading

Codecov Report

Merging #335 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   90.91%   90.96%   +0.04%     
==========================================
  Files          59       59              
  Lines        1024     1029       +5     
  Branches       37       40       +3     
==========================================
+ Hits          931      936       +5     
  Misses         93       93
Impacted Files Coverage Δ
...les/core/shared/src/main/scala/cron4s/errors.scala 42.85% <ø> (ø)
...e/shared/src/main/scala/cron4s/parsing/lexer.scala 86.20% <ø> (ø)
...re/shared/src/main/scala/cron4s/parsing/base.scala 100.00% <100.00%> (ø)
.../shared/src/main/scala/cron4s/parsing/parser.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d848ed...8e10d4c. Read the comment docs.

@mergify mergify bot merged commit 3b6dc10 into master Aug 21, 2020
@mergify mergify bot deleted the Fix-exception-when-expr-is-too-short branch August 21, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing errors not in either left
1 participant
@alonsodomin